On Tue, 30 Sep 2025 18:03:54 GMT, Andy Goryachev <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   rename field
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ViewSceneOverlay.java
>  line 55:
> 
>> 53:         this.subscription = Subscription.combine(
>> 54:             scene.rootProperty().subscribe(this::onSceneRootChanged),
>> 55:             
>> scene.effectiveNodeOrientationProperty().subscribe(this::onEffectiveNodeOrientationInvalidated));
> 
> side note to @hjohn : 
> would it make sense to add a `Subscription.subscribe(Runnable)` method for 
> cases like this?

I do not have a Linux machine to test it. I am only able to test on mac / win 
which seems to work fine

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1921#discussion_r2394385158

Reply via email to