On Wed, 17 Sep 2025 09:04:12 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Further additions to the MonkeyTester application: >> >> - readme.md: In this command we should not add `javafx-sdk-24` in the path. >> JAVAFX already includes sdk folder we just need to use `java -p >> <JAVAFX>/lib/ --add-modules ALL-MODULE-PATH -jar MonkeyTester.jar` >> - TableView page: canvas based cell and row factories >> - Dialog page >> - Progress Bar Page >> - additional scripts in the WritingSystemsDemo >> - pure Swing JTextField/JTextArea window >> - ImageView page >> - AudioClip page >> - events in Drag and Drop page >> - added miscellaneous options >> - TextFlow page: updated hit info visualization, tab stop policy >> - WebView page: added direct html input >> >> Also, upgraded the build scripts and eclipse settings to **JDK24** and >> **JFX24** (you may need to upgrade Eclipse). > > Tested newly added tests on macOS. They look good apart from one observation > regarding DialogPane test. > I have not tested Eclipse settings as I don't use it. Thank you for the comments @aghaisas @arapte ! Made the following changes: 1. added the button bar with a Cancel button to the dialog (without it the dialog won't get closed) 2. the "Show Dialog" button now changes to "Hide Dialog" when the dialog is visible 3. added "Clear Image" popup menu item to the context menu on the ImageView page. I don't want to remove the large image option. Speaking of messing up the setting such that the UI becomes unusable - I was thinking about a global menu option to reset the properties to their default values in the next iteration of the monkey tester. Also, @kevinrushforth once suggested a function to export/import the properties so they can be reproduced exactly (for example, they can be attached to a bug report). I've been thinking about it for a while and it seems like a nice improvement - if only we had APIs to query the default value of properties somehow. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1887#issuecomment-3304501084
