On Fri, 12 Sep 2025 19:14:54 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

>> Issue: 
>> On MacOS, several tests fail intermittently.
>> 
>> Fix: 
>> - The test TableViewContextMenuSortTest.testContextMenuRequestDoesNotSort() 
>> performs a Ctrl + Click test only on MacOS platform.
>> - If the Ctrl + Click is avoided, then the test failures are not observed.
>> - So this change comments out the part of the test in question.
>> - A follow-up ticket is created to investigate/update the test 
>> [JDK-8367566](https://bugs.openjdk.org/browse/JDK-8367566)
>> 
>> Verification:
>> 1. Verified the headful test with full run, 12 times. The issue does not 
>> occur.
>> Without this change, the tests do fail more often.
>> 2. @beldenfox shared a way to reproduce the failures, in a comment in JBS 
>> ticket : [JDK-8359154](https://bugs.openjdk.org/browse/JDK-8359154)**:** If 
>> these 5 tests are run repeatedly TableViewClickOnTroughTest, 
>> TableViewContextMenuSortTest, TableViewResizeColumnToFitContentTest, 
>> TreeTableViewChangeRootTest, and TreeTableViewResizeColumnToFitContentTest, 
>> then the issue could occur in 'n' iterations < 120. 
>> With this change, no test failure is observed. Several times, tested 120 
>> iterations.
>
> Ambarish Rapte has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   update comment

Marked as reviewed by kcr (Lead).

Since this is just skipping a failing test, OK to integrate without waiting 24 
hours.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1899#pullrequestreview-3218496737
PR Comment: https://git.openjdk.org/jfx/pull/1899#issuecomment-3286546843

Reply via email to