On Wed, 10 Sep 2025 21:16:32 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I updated it and removed the `ScreenCaptureTestWatcher` > > Perhaps we should keep it for a while, to capture the screenshot if it fails > (there is almost zero overhead in keeping it if the tests don't fail). > > We could create a followup ticket to remove it in the next test sprint. > > What do you think? Not without qualifying it on a gradle property that is off by default. We discussed this when the new screenshot utility was first introduced. If this is a developer convenience, then it's fine as is without being qualified. Developers can enable it as needed. If this is ever checked into our repo, then I want a gradle property to enable it, where the default is false. Current, we do the former. I'd be fine doing the latter and then added it as needed to intermittently failing tests. We could have our nightly headful test job set that gradle property, but I don't want it on by default when developers run "gradle ... test". ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1893#discussion_r2337948093
