On Thu, 4 Sep 2025 12:23:28 GMT, danielpeintner <d...@openjdk.org> wrote:
>> This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 24. >> >> In order for JavaFX to be able to use more recent JDK features, we should >> increase the minimum version of the JDK that can run the latest JavaFX. >> Additionally, there is an ongoing cost to keeping JavaFX buildable and >> runnable on older versions of Java, and little reason to continue to do so. >> >> This continues our current practice of setting the minimum JDK for JavaFX N >> to JDK N-2. JavaFX N is primarily intended for use with JDK N and we also >> build and test it against JDK N-1 (which is typically what we use as the >> boot JDK). Anything older than that, including the proposed minimum JDK N-2 >> (24 in this specific case), is untested. >> >> This PR targeted to JavaFX 26, and must not be backported to any earlier >> version. This needs a CSR and a release note. > > build.properties line 94: > >> 92: jfx.build.jdk.buildnum=9 >> 93: jfx.build.jdk.version.min=24 >> 94: jfx.build.jdk.buildnum.min=36 > > Suggestion: > > jfx.build.jdk.buildnum.min=38 > > > Not 100% sure but I think the number should _increase_ and not _decrease_ No. Build numbers are only meaningful within a specific release. JDK 23 GA was build 37 (jdk-23+37). JDK 24 GA was build 36 (jdk-24+36). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1883#discussion_r2321931310
