On Wed, 20 Aug 2025 23:33:16 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Support background loading of raw input streams >> >> - Fixed generics (mix up of two ImageLoader types) >> - Removed unused code for handling headers, methods, request parameters >> - Use `long` for progress as streams may exceed 2 GB >> - Improved documentation of Image regarding background loading > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo If user is passing stream its better to keep the decision of closing the stream with user for synchronous loading. Asynchronous URL loading : Current changes takes care of closing the stream and follows already present behaviour. Its better to update the documentation about it. Asynchronous InputStream loading : This change now explicitly closes the Input Stream which is fine but this needs to be captured in the documentation. Giving an option to user about how to close the stream in case of asynchronous loading can be taken up as future task, if needed. CI testing is green with current code update. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1875#issuecomment-3212798073
