On Thu, 26 Jun 2025 12:05:14 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use appropriate layer for setting opacity > > modules/javafx.graphics/src/main/native-prism-mtl/MetalContext.h line 78: > >> 76: id<MTLRenderCommandEncoder> phongEncoder; >> 77: id<MTLRenderCommandEncoder> lastPhongEncoder; >> 78: MetalShader* currentShader; > > Might be my obj-C lack-of-knowledge - why some objects here use pointers, > while others use `id<>`? They are little similar with `*` offering more type safety. But in our case we have used `id<>` for metal library objects and `*` instances of interfaces from our implementation. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2206434035
