On Thu, 5 Jun 2025 21:31:26 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8357393.attr.ser >> - javadoc >> - Merge remote-tracking branch 'origin/master' into 8357393.attr.ser >> - test >> - tests >> - fixed attribute serialization > > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/StyleAttributeMapHelper.java > line 57: > >> 55: * >> 56: * @param ss the style attribute map >> 57: * @return the instance of StyleAttributeMap, or null > > Is there a good reason to allow null here? Unless there is a semantic > difference between null and the empty map, it might be easier to make this > non-nullable. This could be done later, since the fact that it can return > null is preexisting. I've recorded this in the feedback document - this might be worth doing. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1813#discussion_r2130561873
