On Wed, 30 Apr 2025 03:38:34 GMT, Martin Fox <m...@openjdk.org> wrote:

>> On macOS the system animates the transition into and out of fullscreen and 
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen 
>> call appear synchronous by running a nested event loop while the transition 
>> is going on. But this means that runLater runnables can fire during a call 
>> to setFullScreen.
>> 
>> This can also occur during a call to Window.hide() if the window is in 
>> fullscreen mode. During the setView call glass tries to take the window out 
>> of fullscreen mode which fires up a nested event loop and, again, runLater 
>> runnables (like pulses) start firing.
>> 
>> In this PR GlassRunnables that try to run during the fullscreen transition 
>> are instead placed in a deferral list. When the fullscreen event loop exits 
>> they are re-scheduled.
>
> Martin Fox has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Bumping up delay to ensure fullscreen transition is done on macOS

lgtm, thanks!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1797#pullrequestreview-2807268609

Reply via email to