On Fri, 25 Apr 2025 16:48:40 GMT, Martin Fox <m...@openjdk.org> wrote:
>> @beldenfox Do you think we should address that issue (ctrl+left click + >> columnReordering) in this PR? Else, do we need to do anything else to move >> it forward? > > You should be good with a few tweaks. If the press event is a popup trigger > don't set the columnDragLock or call columnReorderingStarted (since you might > not get a release event). In the drag handler check > popupTriggeredOnMousePressed and do nothing if it's set. Your released > handler looks fine as-is. I think that should cover it. > > By the way, in a perfect world you would have more predictable behavior. When > the popup menu is shown it would grab the mouse pointer and you would never > see the release event. That would allow the user to click to bring up the > popup and start dragging across the menu items without having to release the > mouse. Thanks, @beldenfox! I've included your suggestions, and also added the ctrl+left click macOS case to the test. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1754#discussion_r2063378261
