On Mon, 14 Apr 2025 21:39:48 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Also, since the proposed fix is in JavaFX, the JBS bug needs to be updated >> to the correct component/subcomponent/version. I can do that and also assign >> the bug to @FlorianKirmaier since you list him as a co-author of this fix. >> If you wish to have Skara record Florian as a co-author, you can use Skara's >> `/contributor add` command. > >> Also, since the proposed fix is in JavaFX, the JBS bug needs to be updated >> to the correct component/subcomponent/version. > > I see that it's not quite that simple, since there is a corresponding AWT fix. > > You cannot use the same bug ID for both a JDK fix and a JavaFX fix. File a > separate bug for the JavaFX half of the fix, and use that new bug for this > JavaFX PR. Perhaps @FlorianKirmaier can do this? > > The two fixes will need to be done and tested both independently and > together. It is OK if the bug isn't fully fixed without both halves of the > fix. However, it is not OK for it to misbehave in some other way (exception, > crash, etc) if you run a JavaFX without the fix with an JDK with the fix or > vice versa. > > So there now needs to be a matrix of testing that includes: > > (JDK without/with fix) X (JavaFX without/with fix) > > For each of those 4 cases you will need to test: > > * JavaFX + Swing app -- JavaFX Toolkit initialized first > * JavaFX + Swing app -- AWT Toolkit initialized first @kevinrushforth could You please take a look again now? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1755#issuecomment-2813106296
