On Wed, 12 Mar 2025 13:56:58 GMT, Abhinay Agarwal <d...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review feedback > > doc-files/release-notes-24.md line 50: > >> 48: ``` >> 49: >> 50: NOTE: The above will fail if you run your application with JDK 23 or >> earlier. JDK 24 is recommended when running JavaFX 24, but if you choose to >> run JavaFX 24 with an earlier JDK, use the `--module-path` option instead. > > Should the `NOTE` be changed to use Github supported [highlight using > blockquote](https://github.com/orgs/community/discussions/16925): > > >> [!NOTE] >> The above will fail if you run your application with JDK 23 or earlier. JDK >> 24 is recommended when running JavaFX 24, but if you choose to run JavaFX 24 >> with an earlier JDK, use the `--module-path` option instead. I'll leave this as is for now, since we are so close to release. I'd also want to check out what GitLab does with it as well. This might be worth doing for next time. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1994390569
