On Thu, 27 Feb 2025 18:54:45 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - merge
>> - Merge branch 'master' into fixes/vetoable-list-decorator-sort
>>
>> # Conflicts:
>> #
>> modules/javafx.base/src/main/java/com/sun/javafx/collections/VetoableListDecorator.java
>> - factor out setAll implementation
>> - Implement sorting for VetoableListDecorator
>> - failing tests
>
> modules/javafx.base/src/main/java/com/sun/javafx/collections/VetoableListDecorator.java
> line 127:
>
>> 125:
>> 126: private boolean setAllImpl(List<E> unmodifiableList) {
>> 127: onProposedChange(unmodifiableList, 0, size());
>
> Have you thought of moving all the checks and wrapping into `setAllImpl()`?
>
> Regardless of that, the current code is good.
The wrappers are slightly different (`UnmodifiableArrayList` vs
`Collections.unmodifiableList`), so doing that would be a little less efficient.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1674#discussion_r1974492296
