On Tue, 11 Feb 2025 22:22:59 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> ## Root Cause >> >> Each time a `PaginationSkin.IndicatorButton` gets created it adds two >> listeners (to the control's `styleClass` property and to the skin's >> tooltipVisible property) via `ListenerHelper`. This was not detected by the >> `SkinMemoryLeakTest` because all listeners got removed correctly upon skin >> change. >> >> ## Solution >> >> Add a single listener to the control's `styleClass` property at the skin >> level, and insert the call to the skin's `tooltipVisible` property both of >> which iterate over indicator button to do their thing. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > back to constructor Marked as reviewed by kcr (Lead). ------------- PR Review: https://git.openjdk.org/jfx/pull/1705#pullrequestreview-2610227477
