On Tue, 11 Feb 2025 17:55:25 GMT, Oliver Schmidtmer <oschmidt...@openjdk.org> wrote:
>> Webkit JavaFx upgrade from 619.1 to 620.1 <br> >> Build is verified in mac , windows and linux. Sanity testing looks fine. No >> issues seen, except one observed CanvasPattern test where it works only on >> Linux but failed on Mac/Windows (WIP). >> Windows build is using clang-cl compiler because Webkit has dropped MSVC >> compiler support. > > modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJava.cpp > line 1: > >> 1: /* > > I would recommend to add "fprintf(stderr, XXX NOT IMPLEMENTED\n");" outputs > to the the four changed / new functions stubs, as for the older unimplemented > methods. > This would make issues as we had in > [JDK-8337481](https://bugs.openjdk.org/browse/JDK-8337481) easier to track. That's a good idea. @jaybhaskar Can you either make this change or else file a follow-up issue? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1703#discussion_r1951370805
