On Fri, 7 Feb 2025 18:41:53 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> ## Root Cause >> Animation gets started in a background thread, which causes the animation >> handler to run in the FX application thread, thus creating simultaneous >> access to the control's fields (list of children in this case). >> >> ## Solution >> Postpone the animation unless running in the FX application thread. There >> is no functional difference if the component is created/used in the FX >> application thread. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into 8349105.thread.safety.pagination > - postpone animation A quick test suggests that there is still something up with Pagination that increasing the memory won't fully resolve. Even bumping it up to 2Gb fails sometimes on my Mac (e.g., if I increase the duration to 10 sec). I added `-verbose:gc` and the memory shoots up to almost 2Gb and doesn't really ever go down. None of the other tests come even close to hitting a memory problem, and when a GC happens, the memory in use drops down to about 12-15 Mbytes (not surprising given that the entire test suite runs with the default heap size if pagination is disabled). More study is needed, so let's pick this up next week. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1698#issuecomment-2644250937
