On Wed, 5 Feb 2025 21:33:52 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java
>>  line 782:
>> 
>>> 780:             new Thread(() -> {
>>> 781:                 try {
>>> 782:                     while (running.get()) {
>> 
>> Maybe exit early if there is a failure, e.g., `while (running.get() && 
>> !failed.get())`?
>> 
>> In order to be effective, the `UncaughtExceptionHandler` would need to 
>> interrupt the main thread (so that `sleep(DURATION)` terminates early), so 
>> we would need to register the main thread with the 
>> `UncaughtExceptionHandler`.
>> 
>> This could be a follow-on if we decide it is helpful (I'm not sure it's 
>> worth doing).
>
> Probably not worth doing it - the test is relatively quick (even after we add 
> all other  Nodes).

Also, this would only bail out of a single test method, so very likely not 
worth it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1943827541

Reply via email to