On Fri, 10 Jan 2025 21:09:01 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Added ant build to the RichTextAreaDemo project. > > ## Building > > Build: run `ant` command in the project directory. > > ## Running Demos > > Use the following commands to run demos build in the previous section: > > Code Area Demo: `ant run-codearea-demo` > > Notebook Demo: `ant run-notebook-demo` > > Rich Editor Demo: `ant run-richeditor-demo` > > RichTextArea Tester: `ant run-richtextarea-demo` This works for me, and looks good with one suggestion. The various "run" targets launch the demo in the background, which none of our other build scripts do. I think it should wait for the demo to complete; the user can put the "ant run..." in the background if they want to. As it is, it we couldn't put this into a script that runs a set of demos one after another, starting each one with the previous was closed (we have scripts like that that I use for sanity testing). apps/samples/RichTextAreaDemo/build.xml line 79: > 77: > 78: <target name="run-codearea-demo"> > 79: <exec executable="java" spawn="true"> I would remove the `spawn="true"`. ------------- PR Review: https://git.openjdk.org/jfx/pull/1672#pullrequestreview-2544204941 PR Review Comment: https://git.openjdk.org/jfx/pull/1672#discussion_r1911637535
