On Wed, 8 Jan 2025 23:47:10 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> The CSS Selectors specification defines the `:root` pseudo-class that 
>> matches root nodes:
>> https://www.w3.org/TR/selectors-4/#the-root-pseudo
>> 
>> JavaFX uses the non-standard `.root` style class for the same purpose. We 
>> should also support the `:root` pseudo-class for increased compatibility of 
>> JavaFX CSS with the web specification.
>> 
>> Additionally, we should also support the following child-indexed 
>> pseudo-classes:
>> `:first-child`
>> `:last-child`
>> `:only-child`
>> `:nth-child()` with arguments `even` and `odd`
>> 
>> The `An+B [of S]?` microsyntax for `:nth-child()` is not supported, as this 
>> would require major changes in JavaFX CSS.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   updated cssref

I am not a big fan of CSS in its current state, but that's not important.

The important part is that in 99.9% of use cases we won't see a difference, and 
there might be some use for this feature.  May be a note somewhere (css ref?  
not sure where we could add a javadoc note) might be helpful, but really, once 
you are dealing with 10,000 of nodes in one parent you are doing something 
wrong.

I am ok with integrating this PR as is.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1652#issuecomment-2581099419

Reply via email to