On Wed, 8 Jan 2025 23:47:10 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> The CSS Selectors specification defines the `:root` pseudo-class that 
>> matches root nodes:
>> https://www.w3.org/TR/selectors-4/#the-root-pseudo
>> 
>> JavaFX uses the non-standard `.root` style class for the same purpose. We 
>> should also support the `:root` pseudo-class for increased compatibility of 
>> JavaFX CSS with the web specification.
>> 
>> Additionally, we should also support the following child-indexed 
>> pseudo-classes:
>> `:first-child`
>> `:last-child`
>> `:only-child`
>> `:nth-child()` with arguments `even` and `odd`
>> 
>> The `An+B [of S]?` microsyntax for `:nth-child()` is not supported, as this 
>> would require major changes in JavaFX CSS.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   updated cssref

Looks good to me.  Performance updating 1000 children as tested with the monkey 
tester looks very good (macOS).

One last question to everyone - do you think the change from .root to :root 
should be more pronounced in the CSS ref?

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1652#pullrequestreview-2540441196

Reply via email to