On Tue, 7 Jan 2025 21:20:39 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added html charset > > modules/jfx.incubator.input/src/main/java/com/sun/jfx/incubator/scene/control/input/EventHandlerPriority.java > line 36: > >> 34: USER_KB(5000), >> 35: SKIN_KB(4000), >> 36: SKIN_HIGH(3000), > > Just curious about the logic behind the priorities. Like why for skin kb (is > it keyboard?) if above the high priority but for user high is about kb? I > understand that this is just a search order in which event handlers will be > called and if higher priority handler consumes event it will not be proposed > to the next priority level handler? excellent question! the idea is to have the handler for key bindings (KB) to be checked before other skin handlers, which typically deal with multiple keys or catch-all cases. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1906062787