On Fri, 20 Dec 2024 14:48:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> The changes all look good now. > > I did notice one thing in macOS while reviewing the changes in > `PlatformSupport.m`. The PlatformSupport object stays around after the > GlassApplication is terminated via finishTerminating. It will continue to > process platform events, including making Java upcalls even after the FX > toolkit is stopped. You would only see this with a Swing interop app that > initializes FX and then later terminates it while keeping AWT alive. I think > it is preexisting, and doesn't seem to be causing any problems. It might be > worth a P4 follow-up issue to investigate. I've added some code that ensures that the `PlatformSupport` instance stops event processing and is released when `GlassApplication` shuts down. I've verified this by logging whether `dealloc` is called, which it is. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1656#issuecomment-2557478491
