On Tue, 3 Dec 2024 10:43:42 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test for Height > > Good timing with the height test, I was mid-verification, about to suggest > adding it :) > > On my end the test does pass on Ubuntu 22.04 with Xorg and with the fix. > However, without the fix, the tests still succeed despite the GTK assertions > showing up: > > >> gradle --info -PUSE_ROBOT=true -PFULL_TEST=true :systemTests:test --tests >> StageMixedSizeTest > ... > Successfully started process 'Gradle Test Executor 479' > > > (java:29375): Gtk-CRITICAL **: 11:38:34.936: gtk_window_resize: assertion > 'width > 0' failed > > (java:29375): Gtk-CRITICAL **: 11:38:36.596: gtk_window_resize: assertion > 'height > 0' failed > Gradle Test Executor 479 finished executing tests. > > > Not having an actually failing test when there's a problem kind of > invalidates the reason for tests to exist, these messages will probably be > drowned in the sea of log messages. Do you think there is a way to capture > those and fail the test (even as a follow-up)? I see the same behavior as @lukostyra -- the current version of the test no longer catches the error. I took a quick look and didn't spot anything. The timeline looks correct; the sleep now looks redundant since you wait for 500ms in the timeline and then again after the latch.await, but that wouldn't cause the test to miss catching the error. Odd. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1654#issuecomment-2515712796
