On Tue, 3 Dec 2024 13:19:54 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 72 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - since 24 >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - hide skin input map >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - ... and 62 more: https://git.openjdk.org/jfx/compare/67eed6d8...4b27b891 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/SelectionModel.java > line 74: > >> 72: * @param pos the new caret position, must be non-null >> 73: */ >> 74: public void extendSelection(StyledTextModel model, TextPos pos); > > Kind of picky-thinking of nomenclature here (but do correct me if I'm wrong) > - "extend" strictly means to make something larger, while this assumes you > can also make the selection smaller. > > How does `modifySelection` or `adjustSelection` sound like instead? named after `TextInputControl.extendSelection()` L1126 I might leave it as is for consistency sake. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1868040934
