On Sun, 17 Nov 2024 20:18:28 GMT, Martin Fox <m...@openjdk.org> wrote:
> The GlassFullscreenWindow class hasn't been instantiated since applet support > was removed (JDK-8201538). This PR removes the class and the one (unused) > member variable of that type. Nice cleanup. I reviewed all of the code changes, and this all looks good. In addition to reviewing it, I instrumented the code to verify that `fullScreenWindow` is always null (it is). After applying your patch, I see no more references to the dead classes and the unused (always null) `fullScreenWindow` and `fsWindow` fields. I fired off a headful test build on our macOS platforms and will approve it once it passes. @beldenfox You will need to change the title of this PR to match the JBS title (I modified it slightly for consistency, but the mismatch was there before I did that). ------------- PR Comment: https://git.openjdk.org/jfx/pull/1641#issuecomment-2484259291
