On Wed, 13 Nov 2024 18:07:37 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> The bug is present in TableView and TreeTableView, but not TreeView - is this
> correct?
Yes since `ListView` and `TreeView` do not need to do any synchronization when
their index or item changed. But I did not test them.
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java
> line 6335:
>
>> 6333: @Test
>> 6334: void testReSetItemsWithSameItemShouldUpdateCellIndices() {
>> 6335: table.setFixedCellSize(24);
>
> fixed size is not essential to the test, right? I've tested with the SCCE in
> the ticket, it has no effect.
>
> it's probably ok to leave it here though.
Ah yes, I used it initially to better predict the `ScrollBar`, but is indeed
not necessary.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1635#issuecomment-2474617765
PR Review Comment: https://git.openjdk.org/jfx/pull/1635#discussion_r1841075029
