On Thu, 7 Nov 2024 19:33:11 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Leave the Xcode-select commented out for clarity > > .github/workflows/submit.yml line 301: > >> 299: which ant >> 300: ant -version >> 301: sudo xcode-select --switch >> /Applications/Xcode_14.3.1.app/Contents/Developer > > do you think it might be better to comment out this line, in case we need > emergency override? Sure. It might also save a question from someone wondering why we do an `xcode-select` for macOS 13 but not macOS 14 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1630#discussion_r1833251386
