On Thu, 7 Nov 2024 13:23:24 GMT, Glavo <d...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8342992-check-sm
>> - 8342992: Security manager check should not use deprecated methods
>
> modules/javafx.base/src/main/java/com/sun/javafx/SecurityUtil.java line 48:
>
>> 46: * @throws UnsupportedOperationException if the security manager is
>> enabled
>> 47: */
>> 48: public static void checkSecurityManager() {
>
> Can we cache the results of the check?
I thought about doing that. In fact, I even coded it up, but since it only
called at most 4 times (once for each of the 4 call sites) at startup, I wasn't
sure it was worth it. I don't mind either way.
@arapte do you have an opinion?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1627#discussion_r1832751292
