On Thu, 7 Nov 2024 14:08:09 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> This is a proof of concept fix for the linked issue. > > We'll need to discuss if using an event filter in the Behavior is the > appropriate fix and how much impact this may have on current applications. The failing `SpinnerTest::testEnterEscapeKeysWithDefaultCancelButtons` test is a bit odd; it expects that Enter in an **editable** Spinner should result in activating the Default Button. However, a normal TextField doesn't do this either... In a non-editable Spinner, the default button logic works as expected. As it is, we can't have both; the bug wants to not have Enter bubbling up, but then the default button logic is not going to work. IMHO, Spinner's text field should work like regular text fields, so if Enter in those fields can't activate the default button, then neither should Spinner's editable field. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1629#issuecomment-2462406355
