On Thu, 31 Oct 2024 16:22:11 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review fixes
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/RendererStats.java line
> 362:
>
>> 360: private RendererStatsHolder() {
>> 361: AccessController.doPrivileged(
>> 362: (PrivilegedAction<Void>) () -> {
>
> There are unused imports after this change.
Done
> modules/javafx.graphics/src/main/java/javafx/scene/PropertyHelper.java line
> 38:
>
>> 36: } catch (Exception any) {
>> 37: }
>> 38: return false;
>
> Following the removal of the doPrivileged call, the second sentence in the
> comment block of this method -- starting with "Note that ..." -- is wrong and
> can be removed.
Done
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1448:
>
>> 1446: final AccessControlContext acc = AccessController.getContext();
>> 1447: snapshotRunnableList.add(() -> {
>> 1448: AccessController.doPrivileged((PrivilegedAction<Void>) ()
>> -> {
>
> I think that this method has a now-unneeded `SuppressWarnings` annotation.
Done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825624171
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825628050
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825628715
