On Tue, 15 Oct 2024 18:18:18 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move native method to Application > > modules/javafx.graphics/src/main/native-prism/SwingInterop.c line 27: > >> 25: >> 26: #include <jni.h> >> 27: #include "com_sun_glass_ui_Application.h" > > unrelated: do we have steps to ensure that the JNI headers are always > included, or it is up to the reviewers? It's up to the reviewers. And short of writing a custom scanner (which I don't think is worth the effort) there really isn't a good way to automate the check. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1600#discussion_r1802032211
