On Wed, 2 Oct 2024 17:33:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/8061673/ > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 14 commits: > > - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal > - removed traversal event > - javadoc > - remove bounds > - whitespace > - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal > - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal > - review comments > - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal > - review comments part 1 > - ... and 4 more: https://git.openjdk.org/jfx/compare/4d3c3661...9e1fa796 I would say instance methods operate on instances, that is, the only change typically expected from them is the change of internal state of that instance. It is true for the focusable property: it's the property of the `Node`. It's a read-only property, meaning something else is setting it (the focus subsystem). The reason for `FocusTraversal` class is to indicate the fact that `traverseXXX` methods impact more than one node, so I would disagree with the statement that this is anti-OO. It is not about that particular node any more, so it should not be an instance method, in my opinion. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1555#issuecomment-2403375102
