On Wed, 9 Oct 2024 15:06:42 GMT, Martin Fox <m...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 2196:
>>
>>> 2194: (sceneFocusOwner != null &&
>>> sceneFocusOwner.getScene() == Scene.this) ? sceneFocusOwner : Scene.this;
>>> 2195:
>>> 2196: if (eventTarget == null) return false;
>>
>> minor: insert braces?
>
> This single-line pattern is used throughout this file. I was under the
> impression that it was within the coding guidelines but can't seem to find a
> citation for that.
It is fine (and used all over the place).
OK:
if (cond) return;
if (cond) {
return;
}
NOT OK:
if (cond)
return;
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1528#discussion_r1793728132
