On Tue, 8 Oct 2024 14:55:48 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> maybe an explanatory comment should be added? > > We typically use `InternalError` for the case where there should be no > possible reason for a particular case, but also use `AssertionError` in some > cases. Either is OK with me. I agree that a comment to the affect of "Should > not ever get here" wouldn't be a bad idea. I've added a comment to `CameraHelper` and `LightBaseHelper`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1556#discussion_r1792050933
