On Sun, 6 Oct 2024 23:15:30 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base 
>> due to a merge or a rebase. The pull request now contains 105 commits:
>> 
>>  - Remove idea file
>>  - Fix the case when IME filters key_press (Polish ALT Gr + C)
>>  - Merge branch 'master' into new_ime
>>  - Fix for Polish AltGR combinations
>>  - Remove negative checks
>>  - Revert idea file
>>  - Remove unused import
>>  - Fix review points
>>  - Merge branch 'master' into new_ime
>>  - Merge branch 'refs/heads/master' into new_ime
>>  - ... and 95 more: https://git.openjdk.org/jfx/compare/5428f267...e56588ba
>
> If I'm following right, the logic is that gtk would trigger the signal inside 
> a key event, an in this case the count would be 1.
> The logic is right, but I suspect the IME system is sending the `commit` 
> signal in some special case for Level 3 Shift / Alt Gr.

@tsayao Yes, we shouldn't be seeing "commit" signals outside of event 
processing. I don't think any OS expects that it can just issue a "commit" to 
hand off a character at some random time, it needs to happen in the context of 
processing an event.  This is all very odd.

This works fine in Ubuntu 22 running X11. And it works fine in Kubuntu 24 
running Plasma on Wayland. In Kubuntu that weird doubling of key events goes 
away so apparently that's not something Gtk is doing. BTW in all of my testing 
I'm using the same JavaFX binaries across different OS versions.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1080#issuecomment-2397862272

Reply via email to