On Mon, 7 Oct 2024 15:28:30 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add information about how ScrollPane acts on key presses.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java
> line 80:
>
>> 78: * ({@link #isFocused()} returns {@code true}) and won't respond to
>> unconsumed
>> 79: * key events that bubble up from a focused child control. The key
>> presses it
>> 80: * acts on are platform specific, but by default should include keys for
>> panning
>
> which keys are platform specific? I could not find any - the behavior
> registers no platform-specific bindings.
Perhaps it should read "may be platform specific" -- I just don't want to pin
FX down on a specific implementation, as FX is aligning with the platforms it
runs on, which it doesn't control. So if one of the platforms at some point
starts using different keys, then I'd expect FX to align with that.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1582#discussion_r1790448472
