On Mon, 7 Oct 2024 14:42:36 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> small changes > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line > 598: > >> 596: * @since 24 >> 597: */ >> 598: ReadOnlyBooleanProperty reducedMotionProperty(); > > Adding a new method without a default implementation to an interface is an > incompatible change. Since we do not expect that an application would ever > implement this interface, this seems OK to me. > > We should either add an `@implSpec` to the class docs indicating that > applications should not implement `Platform.Preferences` or make it a sealed > interface. Good point, I've sealed the interface. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1592#discussion_r1790439003
