On Fri, 4 Oct 2024 18:45:43 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> > You will either need additional methods in `SimpleViewOnlyStyledModel`
> 
> good catch, thanks! the methods exist (`withStyles()`, `withInlineStyle()`, 
> `withInlineAndExternalStyles()`), the docs need to be updated.

Yeah, our comments crossed in the ether. I'm not sure about these names. Also, 
why do we need three of them? At most, I see a need for two, to avoid the 
confusion that cane be caused by the inline style and varargs list of styles 
both being Strings (see our earlier discussion). What do you think?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomment-2394377262

Reply via email to