On Wed, 2 Oct 2024 17:23:11 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/BackgroundPosition.java >> line 55: >> >>> 53: * @since JavaFX 8.0 >>> 54: */ >>> 55: public final class BackgroundPosition implements >>> Interpolatable<BackgroundPosition> { >> >> should we also declare the fields `final` as well? >> horizontalSide, etc. > > All fields of `BackgroundPosition` are already final. Same for `BorderImage` > and `BorderStroke`. sorry, I meant make them `private` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1587#discussion_r1784943241