> This PR modifies the header and footer of the javadoc-generated API docs to 
> add "DRAFT $VER-ea+$BLD" to clearly identify an ea build of the docs, and 
> also to make it clear which build number the docs refer to. This matches was 
> the JDK does. For GA builds, there will be no change to what we generate 
> today. Since I had to add logic to filter the javadoc properties defined in 
> `build.javadoc` to add the DRAFT message if not a GA build, I also changed 
> the properties to not hard-code the major version of JavaFX, thus reducing 
> the duplication.
> 
> I ran three builds to test this, an ordinary developer build, an EA build, 
> and a GA build as follows:
> 
> #### Developer build
> 
> Command line:
> 
> gradle javadoc
> 
> 
> Generated docs: https://cr.openjdk.org/~kcr/8340829/javadoc-internal/
> 
> #### EA build
> 
> Command line:
> 
> gradle -PPROMOTED_BUILD_NUMBER=98 -PHUDSON_BUILD_NUMBER=1234 
> -PHUDSON_JOB_NAME=jfx-dev javadoc
> 
> 
> Generated docs: https://cr.openjdk.org/~kcr/8340829/javadoc-ea/
> 
> #### GA build
> 
> Command line:
> 
> gradle -PMILESTONE_FCS=true -PPROMOTED_BUILD_NUMBER=99 
> -PHUDSON_BUILD_NUMBER=4321 -PHUDSON_JOB_NAME=jfx-dev javadoc
> 
> 
> Generated docs: https://cr.openjdk.org/~kcr/8340829/javadoc-fcs/

Kevin Rushforth has updated the pull request incrementally with one additional 
commit since the last revision:

  Address feedback

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1583/files
  - new: https://git.openjdk.org/jfx/pull/1583/files/71a0428b..2da1f291

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1583&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1583&range=00-01

  Stats: 9 lines in 2 files changed: 5 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/1583.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1583/head:pull/1583

PR: https://git.openjdk.org/jfx/pull/1583

Reply via email to