On Fri, 20 Sep 2024 15:35:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> If it isn't being used, then I like your idea of deleting it. Especially >> since this seems redundant given `Util.sleep(ms)`. I'll revert my changes >> and let you delete it as part of #1569. > > On closer inspection, I don't think this should be removed as part of PR > #1569, since that file is already using JUnit 5 and is not touched by your PR. > > Either I can remove the method with this PR or we just leave it for a > follow-up. Removing it with this PR seems easiest, since I am already > modifying that method as part of this PR (along with other methods that catch > and ignore InterruptedException from sleep). I agree with removing the method in this PR. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1575#discussion_r1768897041
