On Thu, 12 Sep 2024 13:45:04 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> small doc changes, copyright header > > modules/javafx.graphics/src/main/java/javafx/css/TransitionEvent.java line > 109: > >> 107: public TransitionEvent(EventType<? extends Event> eventType, >> 108: StyleableProperty<?> property, >> 109: String propertyName, > > Does this break backwards compatibility? Sure, but I don't really mind: 1. `TransitionEvent` is a CSS event, it can not usefully be created by application developers. 2. This API (without `propertyName`) will be introduced with JFX 23, so developers will need to hurry if they intend to misuse it until JFX 24 rolls around... I wouldn't mind removing the public constructor altogether, but this is not something that we usually do for JavaFX events. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1759683190
