On Fri, 13 Sep 2024 10:45:33 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> This converts FXML module tests to junit5.
>
> All changes are trivial API replacements from junit4 to junit5.
> There are no parameterized tests in this module.
I might suggest fixing the formatting for readability.
This is minor, will re-approve if you decide to fix it.
modules/javafx.fxml/src/test/java/test/javafx/fxml/RT_19008Test.java line 37:
> 35: @Test
> 36: public void testMissingResource() throws IOException {
> 37: assertThrows(NullPointerException.class, () ->
> {FXMLLoader.load(getClass().getResource("rt_19008.fxml"));
minor: I would fix the formatting here (move the lambda to its own line)
modules/javafx.fxml/src/test/java/test/javafx/fxml/RT_19329Test.java line 37:
> 35: @Test
> 36: public void testIncludeException() throws IOException {
> 37: assertThrows(IOException.class, () -> {
> FXMLLoader.load(getClass().getResource("rt_19329.fxml")); });
minor: formatting
modules/javafx.fxml/src/test/java/test/javafx/fxml/RT_25494_Cycle_DetectionTest.java
line 47:
> 45: @Test
> 46: public void test_cycle() throws Exception {
> 47: assertThrows(IOException.class, () ->
> {FXMLLoader.load(RT_25494_Cycle_DetectionTest.class.getResource("cycle.fxml"));
> });
... and here for readability
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1564#pullrequestreview-2303335860
PR Review Comment: https://git.openjdk.org/jfx/pull/1564#discussion_r1759005526
PR Review Comment: https://git.openjdk.org/jfx/pull/1564#discussion_r1759006194
PR Review Comment: https://git.openjdk.org/jfx/pull/1564#discussion_r1759007072
