On Tue, 10 Sep 2024 08:13:44 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Following 2 warnings are observed with the JavaFX build. >> These warnings need to be addressed for updating to Gradle 9.0 in future. >> >> 1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. >> This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide >> for further information: >> https://docs.gradle.org/8.9/userguide/upgrading_version_8.html#java_convention_deprecation >> `=>>` This warning gets fixed by the change on line number 2111 in >> build.gradle >> >> 2. The automatic loading of test framework implementation dependencies has >> been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the >> desired test framework directly on the test suite or explicitly declare the >> test framework implementation dependencies on the test's runtime classpath. >> Consult the upgrading guide for further information: >> https://docs.gradle.org/8.9/userguide/upgrading_version_8.html#test_framework_implementation_dependencies >> `=>>` This warning gets fixed by the change on line number 2128 in >> build.gradle. It also requires the verification metadata to be updated. >> >> Verification: >> 1. Verify that build completes successfully >> 2. Above two warnings are not observed in build log. >> 3. This warning message is NOT observed in build log: Deprecated Gradle >> features were used in this build, making it incompatible with Gradle 9.0. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > fix for windows warning Looks good now. I get no warnings on Windows now. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1559#pullrequestreview-2292974257
