On Wed, 7 Aug 2024 22:54:10 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I considered doing more here, but as this is all just moved code, I'm >> hesitant to change it as part of this PR. For example, if there is a faulty >> binary CSS file which has a negative value for the short, then the original >> code will just skip the loop. If I add a check, it will change the behavior. > > Well, we could create a separate ticket. I already cleaned it up without altering the behavior. It probably isn't worth investing more time in. The whole binary CSS code is AFAICS basically only used to create binary versions of the FX standard css files, like `modena.css`, by calling the main method of `Css2Bin` during the gradle build. This probably saves some time for JavaFX startup as the binary version will load faster than the text versions (or so I hope, I didn't check if that's true). I have doubts it is used anywhere else, so although this has creeped into a few public API's, it's practically for internal use only. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1708072735
