On Fri, 2 Aug 2024 01:25:06 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/StyleableObjectProperty.java >> line 273: >> >>> 271: >>> 272: private StyleOrigin origin = null; >>> 273: private TransitionController<T> controller = null; >> >> minor: `= null` is unnecessary > > I agree. Not sure if I should remove it from all of the StyleableProperty > implementations, as the `origin = null` is already there. I know what @kevinrushforth would say: "it is better to avoid introducing unrelated changes" as long as the new code omits `= null` we should be fine. (rationale for omitting: explicit initialization creates an unnecessary step in the debugger) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1701970897
