On Wed, 19 Jun 2024 14:25:52 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - process more reviewer comments >> - Process reviewer comments > > tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java > line 321: > >> 319: Stage stage = new Stage(); >> 320: stage.setScene(new Scene(root)); >> 321: stage.show(); > > I think, a CountDownLatch should be added to make sure that stage is shown > before proceeding. One correction: `Stage.show` is not a blocking call. I haven't looked at it closely, but perhaps what @arapte meant was to suggest that the test wait on a latch that is triggered when the Stage::showing event is delivered? Many of our headful tests do that, but I don't know whether that would be applicable here or not. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1670667153
