On Mon, 6 May 2024 18:46:33 GMT, eduardsdv <d...@openjdk.org> wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> commits since the last revision: >> >> - tests >> - cleanup >> - node orientation >> - Merge remote-tracking branch 'origin/master' into 8313138.horizontal >> - table view behavior >> - tree view behavior >> - list view behavior >> - orientation >> - Merge remote-tracking branch 'origin/master' into 8313138.horizontal >> - Merge branch 'master' into 8313138.horizontal >> - ... and 4 more: https://git.openjdk.org/jfx/compare/3483d28c...5bae5e7a > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ListViewSkin.java > line 686: > >> 684: right = !right; >> 685: } >> 686: ScrollBar sb = flow.getHbar(); > > The ListView has the orientation property > ``ListView.setOrientation(Orientation)``. > I think it should be > > ScrollBar sb = flow.isVertical() ? flow.getHbar() : flow.getVbar(); > > and the name of the method something like ``crossUnitScroll(boolean)``.
I am afraid this suggestion is incorrect: the new key bindings affect horizontal scroll bar regardless of the orientation. The new behavior can be checked with the Monkey Tester https://github.com/andy-goryachev-oracle/MonkeyTest ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1393#discussion_r1591492253
