On Mon, 6 May 2024 17:39:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java
>> line 417:
>>
>>> 415: * integer values.
>>> 416: * <p>
>>> 417: * If {@link #wrapAround} is {@code true}, the {@code
>>> IntegerSpinnerValueFactory} will step from
>>
>> The link for wrapAround does not resolve in Eclipse.
>> I'd suggest to change it to
>>
>> * If {@link SpinnerValueFactory#wrapAround wrapAround}
>>
>>
>> Same comment applies to the min and max in line 420.
>
> I don't think this will help. This is the same issue I mentioned in PR #1389
> -- you need to link to the property _method_, so I think changing to the
> following will do it:
>
>
> * If {@link #wrapAroundProperty wrapAround}
>
>
> (it shouldn't be necessary to qualify it with the enclosing class, but it
> wouldn't hurt to do so)
`{@link #wrapAroundProperty wrapAround}` does not resolve **in Eclipse** (it
does in javadoc output).
This might be Eclipse limitation, but it would be awfully nice to have it
resolved in Eclipse.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591370127
