On Wed, 24 Apr 2024 15:26:27 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Interesting = @kevinrushforth what do you think? > > An excellent question. If it is robust, then it seems OK. Using Junit5 > Assumptions is more flexible, though, so might lean toward wanting to use > that. Either way, test this on the other platforms to ensure that the test is > skipped (and marked as skipped in the report). +1 for flexibility. Switched in [`ade506c` (#1442)](https://github.com/openjdk/jfx/pull/1442/commits/ade506c0e44544f3d61a164765e19b983a99373d). Note that `assumeTrue` also works in `@BeforeAll` to skip the whole class. (I wonder whether I should rewrite the other tests following that pattern, but that is maybe a job for a follow-up issue) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1578941716
